Talk About Network

Google


Register and Login
Nick
Password
Register create new account Sign up is FREE and you can post replies, new topics, bookmark posts and more!
Recover lost password


Data Bases > Pgsql Committers > Re: pgsql: Re**...
Latest [ Topics | Posts ] Archive Post A New Topic Post a Reply
<< Topic < Post Post 4 of 8 Topic 16128 of 18152
Post > Topic >>

Re: pgsql: Re****t which WAL sync method we are trying to change *to* when it

by tgl@[EMAIL PROTECTED] (Tom Lane) May 12, 2008 at 03:26 PM

Magnus Hagander <magnus@[EMAIL PROTECTED]
> writes:
> Simon Riggs wrote:
>> Could we re****t both? 

> Yes, we could easily do that if we want to. 

It would be entirely silly to do so, since (a) the old value hasn't been
changed if we fail here, and (b) it's irrelevant to the nature of the
error.

What's also a bit silly is using PANIC for this re****t --- AFAICS plain
old ERROR is sufficient, since if we fail here we have not yet modified
any persistent state.  Just because it's a "can't happen" condition
doesn't justify making it a PANIC.

			regards, tom lane

-- 
Sent via pgsql-committers mailing list (pgsql-committers@[EMAIL PROTECTED]
)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
 




 8 Posts in Topic:
pgsql: Report which WAL sync method we are trying to change *to*
mha@[EMAIL PROTECTED] (M  2008-05-12 14:27:47 
Re: pgsql: Report which WAL sync method we are trying
simon@[EMAIL PROTECTED]   2008-05-12 20:04:25 
Re: pgsql: Report which WAL sync method we are trying
magnus@[EMAIL PROTECTED]   2008-05-12 21:06:30 
Re: pgsql: Report which WAL sync method we are trying to change
tgl@[EMAIL PROTECTED] (T  2008-05-12 15:26:03 
Re: pgsql: Report which WAL sync method we are trying
simon@[EMAIL PROTECTED]   2008-05-12 20:46:12 
Re: pgsql: Report which WAL sync method we are trying to change
tgl@[EMAIL PROTECTED] (T  2008-05-12 15:49:31 
Re: pgsql: Report which WAL sync method we are trying
magnus@[EMAIL PROTECTED]   2008-05-12 21:49:15 
Re: pgsql: Report which WAL sync method we are trying
simon@[EMAIL PROTECTED]   2008-05-12 20:59:48 

Post A Reply:
  Go here to Signup

AddThis Feed Button


About - Advertising - Contact - Frequently Asked Questions - Privacy Policy - Terms of Use - Signup

Contact
tan12V112 Tue Dec 2 1:03:40 CST 2008.