Log Message: ----------- Rewrite DROP's dependency traversal algorithm into an honest two-pass algorithm, replacing the original intention of a one-pass search, which had been hacked up over time to be partially two-pass in hopes of handling various corner cases better. It still wasn't quite there, especially as regards emitting unwanted NOTICE messages. More im****tantly, this approach lets us fix a number of open bugs concerning concurrent DROP scenarios, because we can take locks during the first pass and avoid traversing to dependent objects that were just deleted by someone else. There is more that can be done here, but I'll go ahead and commit the base patch before working on the options. Modified Files: -------------- pgsql/src/backend/access/index: genam.c (r1.68 -> r1.69) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/index/genam.c?r1=1.68&r2=1.69) pgsql/src/backend/catalog: dependency.c (r1.73 -> r1.74) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/catalog/dependency.c?r1=1.73&r2=1.74) pgsql/src/include/access: genam.h (r1.72 -> r1.73) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/access/genam.h?r1=1.72&r2=1.73) pgsql/src/include/catalog: dependency.h (r1.35 -> r1.36) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/dependency.h?r1=1.35&r2=1.36) pgsql/src/test/regress/expected: alter_table.out (r1.106 -> r1.107) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/alter_table.out?r1=1.106&r2=1.107) create_view.out (r1.11 -> r1.12) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/create_view.out?r1=1.11&r2=1.12) domain.out (r1.43 -> r1.44) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/domain.out?r1=1.43&r2=1.44) foreign_key.out (r1.45 -> r1.46) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/foreign_key.out?r1=1.45&r2=1.46) inherit.out (r1.24 -> r1.25) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/inherit.out?r1=1.24&r2=1.25) namespace.out (r1.3 -> r1.4) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/namespace.out?r1=1.3&r2=1.4) plancache.out (r1.6 -> r1.7) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/plancache.out?r1=1.6&r2=1.7) privileges.out (r1.36 -> r1.37) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/privileges.out?r1=1.36&r2=1.37) subselect.out (r1.17 -> r1.18) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/subselect.out?r1=1.17&r2=1.18) truncate.out (r1.14 -> r1.15) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/truncate.out?r1=1.14&r2=1.15) pgsql/src/test/regress/output: tablespace.source (r1.5 -> r1.6) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/output/tablespace.source?r1=1.5&r2=1.6) -- Sent via pgsql-committers mailing list (pgsql-committers@[EMAIL PROTECTED] ) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
