I see that Brendan has proposed the following definition on
CommitFest:Help:
Reviewing items
If you are reviewing an item, let the other developers know by setting
the claimed parameter of the patch to your name. For example, if you
started reviewing the following patch
{{patch|abcd@[EMAIL PROTECTED]
|Add bell and/or whistle|Some Guy}}
you would change it to
{{patch|abcd@[EMAIL PROTECTED]
|Add bell and/or whistle|Some Guy|claimed=Some
Reviewer}}
I'm not too pleased with this because it suggests that "reviewing" is
something only one person can do at a time. What I'd like to see is
guidelines more along these lines:
* Short one-or-two-lines comments can be put right into a {{comment}}
item on the commitfest page.
* If you have a more substantive review, post it on the mailing lists
as a reply to the original patch. Optionally post a link to it as
a {{comment}} on the commitfest page.
* If you are a committer and are taking up the patch for final review
with intent to commit, then mark the commitfest item as "claimed" so
that other committers will not step on your toes.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@[EMAIL PROTECTED]
)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
