Re: bloated heapam.h

This is a multi-part message in MIME format.

--Boundary_(ID_uiYOAIHJEVykO/L6Rto/bQ)
Content-type: text/plain; format=flowed; charset=us-ascii
Content-transfer-encoding: 7BIT

Alvaro Herrera wrote:
> Alvaro Herrera wrote:
> 
>> Oops :-(  I just noticed that I removed bufmgr.h from bufpage.h, which
>> is a change you had objected to previously :-(
> 
> However, it seems the right fix is to move BufferGetPageSize and
> BufferGetPage from bufpage.h to bufmgr.h.

+1 It makes more sense.

> (Digging further, it seems like bufpage.h should also include transam.h
> in order to get TransactionIdIsNormal ... I start to wonder how many
> problems of this nature we have on our headers.  Without having a way to
> detect whether the defined macros are valid, it seems hard to check
> programatically, however.)
> 

I attached script which should check it. In first step it runs C
preprocessor on 
each header (postgres.h is included as well). The output from first step
is 
processed again with preprocessor and define.h is included. Define.h
contains 
"all" used macros in following format:

#define SIGABRT "NOT_EXPANDED_SIGABRT"

Main problem is how to generate define.h. I used following magic:

grep "^#define" `find . -name "*.h"` | cut -d" "  -f 2 | cut -f 1 | cut -f
1 -d"("

but it generates some noise as well. Maybe some Perl or AWK magic should
be better.

		Zdenek

--Boundary_(ID_uiYOAIHJEVykO/L6Rto/bQ)
Content-type: application/x-shellscript; name=test.sh
Content-transfer-encoding: BASE64
Content-disposition: inline; filename=test.sh

IyEvYmluL2tzaAoKZm9yIEZJTEUgaW4gYGZpbmQgLiAtbmFtZSAiKi5oImA7
IGRvCgllY2hvICJQcm9jZXNzaW5nICR7RklMRX0iCgkKICAgICAgICBlY2hv
ICIjaW5jbHVkZSBcInBvc3RncmVzLmhcIiIgPiAgX190ZW1wLmgKCWNhdCAi
JHtGSUxFfSIgPj4gX190ZW1wLmgKCWVjaG8gIiNpbmNsdWRlIFwiZGVmaW5l
LmhcIiIgPiBfX3RlbXAyLmgKCWNjIC1FIC1JIC4gX190ZW1wLmggID4+IF9f
dGVtcDIuaAoJY2MgLUUgLUkgLiBfX3RlbXAyLmggfCBncmVwIE5PVF9FWFBB
TkQKZG9uZQoK

--Boundary_(ID_uiYOAIHJEVykO/L6Rto/bQ)
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@[EMAIL PROTECTED]
)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--Boundary_(ID_uiYOAIHJEVykO/L6Rto/bQ)--