Re: [COMMITTERS] pgsql: Convert wal_sync_method to guc enum.
by tgl@[EMAIL PROTECTED]
(Tom Lane)
May 12, 2008 at 01:35 PM
Magnus Hagander <magnus@[EMAIL PROTECTED]
> writes:
> I need to leave for a couple of hours, will look again when I get back.
> But so far, I'm quite surprised. Here's my reasoning, please poke holes
> in it :-)
I think you forgot to handle SYNC_METHOD_OPEN_DSYNC in issue_xlog_fsync.
If you are going to split SYNC_METHOD_OPEN into two codes, you need to
handle both those codes everywhere SYNC_METHOD_OPEN was formerly
referenced ...
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@[EMAIL PROTECTED]
)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers