Talk About Network

Google


Register and Login
Nick
Password
Register create new account Sign up is FREE and you can post replies, new topics, bookmark posts and more!
Recover lost password


Data Bases > Pgsql Hackers > Re: [COMMITTERS...
Latest [ Topics | Posts ] Archive Post A New Topic Post a Reply
<< Topic < Post Post 2 of 2 Topic 9344 of 10965
Post > Topic >>

Re: [COMMITTERS] pgsql: Convert wal_sync_method to guc enum.

by tgl@[EMAIL PROTECTED] (Tom Lane) May 12, 2008 at 01:35 PM

Magnus Hagander <magnus@[EMAIL PROTECTED]
> writes:
> I need to leave for a couple of hours, will look again when I get back.
> But so far, I'm quite surprised. Here's my reasoning, please poke holes
> in it :-)

I think you forgot to handle SYNC_METHOD_OPEN_DSYNC in issue_xlog_fsync.
If you are going to split SYNC_METHOD_OPEN into two codes, you need to
handle both those codes everywhere SYNC_METHOD_OPEN was formerly
referenced ...

			regards, tom lane

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@[EMAIL PROTECTED]
)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
 




 2 Posts in Topic:
Re: [COMMITTERS] pgsql: Convert wal_sync_method to guc enum.
magnus@[EMAIL PROTECTED]   2008-05-12 17:10:28 
Re: [COMMITTERS] pgsql: Convert wal_sync_method to guc enum.
tgl@[EMAIL PROTECTED] (T  2008-05-12 13:35:35 

Post A Reply:
  Go here to Signup

AddThis Feed Button


About - Advertising - Contact - Frequently Asked Questions - Privacy Policy - Terms of Use - Signup

Contact
tan12V112 Mon Dec 1 9:37:50 CST 2008.