Talk About Network

Google


Register and Login
Nick
Password
Register create new account Sign up is FREE and you can post replies, new topics, bookmark posts and more!
Recover lost password


Data Bases > Pgsql Hackers > Remove redundan...
Latest [ Topics | Posts ] Archive Post A New Topic Post a Reply
<< Topic < Post Post 1 of 8 Topic 9420 of 10966
Post > Topic >>

Remove redundant extra_desc info for enum GUC variables?

by tgl@[EMAIL PROTECTED] (Tom Lane) May 26, 2008 at 03:56 PM

Most of the GUC variables that have been converted to enums have an
extra_desc string that lists the valid values --- in HEAD, try
SELECT name,extra_desc,enumvals from pg_settings where vartype = 'enum';

ISTM this is just about 100% redundant with the enumvals column and
should be removed to reduce translation and maintenance effort.
Any objections?

One point of interest is that for client_min_messages and
log_min_messages, the ordering of the values has significance, and it's
different for the two cases.  The enum patch has lost that info by
trying to use the same auxiliary list for both variables.  But having
two lists doesn't seem like an excessive amount of overhead.

			regards, tom lane

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@[EMAIL PROTECTED]
)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
 




 8 Posts in Topic:
Remove redundant extra_desc info for enum GUC variables?
tgl@[EMAIL PROTECTED] (T  2008-05-26 15:56:48 
Re: Remove redundant extra_desc info for enum GUC
magnus@[EMAIL PROTECTED]   2008-05-27 20:19:20 
Re: Remove redundant extra_desc info for enum GUC variables?
tgl@[EMAIL PROTECTED] (T  2008-05-27 14:24:44 
Re: Remove redundant extra_desc info for enum GUC
magnus@[EMAIL PROTECTED]   2008-05-28 11:10:10 
Re: Remove redundant extra_desc info for enum GUC variables?
tgl@[EMAIL PROTECTED] (T  2008-05-28 11:20:04 
Re: Remove redundant extra_desc info for enum GUC variables?
magnus@[EMAIL PROTECTED]   2008-06-30 21:58:55 
Re: Remove redundant extra_desc info for enum GUC variables?
tgl@[EMAIL PROTECTED] (T  2008-06-30 16:25:00 
Re: Remove redundant extra_desc info for enum GUC variables?
magnus@[EMAIL PROTECTED]   2008-06-30 22:27:41 

Post A Reply:
  Go here to Signup

AddThis Feed Button


About - Advertising - Contact - Frequently Asked Questions - Privacy Policy - Terms of Use - Signup

Contact
tan12V112 Mon Dec 1 12:20:52 CST 2008.