Replying to myself, but I've made some local changes (see other=20=20
messages) and just wanted to follow up on some of my own comments.
On Jul 2, 2008, at 21:38, David E. Wheeler wrote:
>> 4) Operator =3D citext_eq is not correct. See comment
http://doxygen.po=
stgresql.org/varlena_8c.html#8621d064d14f259c594e4df3c1a64cac
>
> So should citextcmp() call strncmp() instead of varst_cmp()? The=20=20
> latter is what I saw in varlena.c.
I'm guessing that the answer is "no," since varstr_cmp() uses=20=20
strncmp() internally, as appropriate to the locale. Correct?
>> There must be difference between equality and collation for example=20=
=20
>> in Czech language 'l=E1ska' and 'lask=E1' are different word it
means=20=
=20
>> that 'l=E1ska' !=3D 'lask=E1'. But there is no difference in collation=
=20=20
>> order. See Unicode Universal Collation Algorithm for detail.
>
> I'll leave the collation stuff to the functions I call (*far* from=20=20
> my specialty), but I'll add a test for this and make sure it works=20=20
> as expected. Um, although, with what collation should it be
tested?=20=20
> The tests I wrote assume en_US.UTF-8.
I added this test and is p*****:
SELECT isnt( 'l=E1ska'::citext, 'lask=E1'::citext, 'Diffrent
accented=20=20
characters should not be equivalent' );
>> 5) There are several commented out lines in CREATE OPERATOR=20=20
>> statement mostly related to NEGATOR. Is there some reason for that?
>
> I copied it from the original citext.sql. Not sure what effect it has.
I restored these (and one of them was wrong anyway).
>> Also OPERATOR || has probably wrong negator.
>
> Right, good catch.
Stupid question: What would the negation of || actually be? There=20=20
isn't one is, there?
Thanks!
David
--=20
Sent via pgsql-hackers mailing list (pgsql-hackers@[EMAIL PROTECTED]
)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
|
