Warning on Backup / Restore FileMenu open

------=_Part_5930_11150387.1209001191315
Content-Type: multipart/alternative; 
	boundary="----=_Part_5931_33119596.1209001191315"


------=_Part_5931_33119596.1209001191315
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi,

When pgAdmin fires the FileMenu while using the Backup Form (the second
time), the wxFileDialog is called with the filepath + filename instead of
just the filename that it expects as its third parameter. This throws up a
warning. The same thing happens with the Restore Form as well.

One such Debug re****t is given below.
Attached is a patch that passes just the FileName to wxFileDialog in both
the forms.

Regards,
*Robins Tharakan*

Debug re****t:
ASSERT INFO:
.../src/common/filename.cpp(476): assert "volDummy.empty() &&
pathDummy.empty()" failed in Assign(): the file name shouldn't contain the
path

BACKTRACE:
[1] wxFileDialog::wxFileDialog(wxWindow*, wxString const&, wxString
const&,
wxString const&, wxString const&, long, wxPoint const&, wxSize const&,
wxString const&)
[2] frmRestore::OnSelectFilename(wxCommandEvent&)
/projects/pgadmin/40_line_numbers_in_sql_view/7/pgadmin/./frm/frmRestore.cpp:136
[3] wxEvtHandler::ProcessEventIfMatches(wxEventTableEntryBase const&,
wxEvtHandler*, wxEvent&)
[4] wxEventHashTable::HandleEvent(wxEvent&, wxEvtHandler*)
[5] wxEvtHandler::ProcessEvent(wxEvent&)
[6] wxWindowBase::TryParent(wxEvent&)
[7] wxEvtHandler::ProcessEvent(wxEvent&)
[8] wxWindowBase::TryParent(wxEvent&)
[9] wxEvtHandler::ProcessEvent(wxEvent&)
[10] wxWindowBase::TryParent(wxEvent&)
[11] wxEvtHandler::ProcessEvent(wxEvent&)
[12] g_closure_invoke()
[13] g_signal_emit_valist()
[14] g_signal_emit()
[15] g_closure_invoke()
[16] g_signal_emit_valist()
[17] g_signal_emit()
[18] g_closure_invoke()
[19] g_signal_emit_valist()
[20] g_signal_emit()
[21] gtk_propagate_event()
[22] gtk_main_do_event()
[23] g_main_context_dispatch()
[24] g_main_loop_run()
[25] gtk_main()

------=_Part_5931_33119596.1209001191315
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

<span style="font-family: verdana,sans-serif;">Hi,</span><br
style="font-family: verdana,sans-serif;"><br style="font-family:
verdana,sans-serif;"><span style="font-family: verdana,sans-serif;">When
pgAdmin fires the FileMenu while using the Backup Form  (the second time),
the wxFileDialog is called with the filepath + filename instead of just the
filename that it expects as its third parameter. This throws up a warning.
The same thing happens with the Restore Form as well.</span><br
style="font-family: verdana,sans-serif;">
<br style="font-family: verdana,sans-serif;"><span style="font-family:
verdana,sans-serif;">One such Debug re****t is given below.</span><br
style="font-family: verdana,sans-serif;"><span style="font-family:
verdana,sans-serif;">Attached is a patch that passes just the FileName to
wxFileDialog in both the forms.</span><br style="font-family:
verdana,sans-serif;">
<br style="font-family: verdana,sans-serif;"><span style="font-family:
verdana,sans-serif;">Regards,</span><br style="font-family:
verdana,sans-serif;"><b style="font-family: verdana,sans-serif;">Robins
Tharakan</b><br style="font-family: verdana,sans-serif;">
<br style="font-family: verdana,sans-serif;"><span style="font-family:
verdana,sans-serif;">Debug re****t:</span><br style="font-family:
verdana,sans-serif;"><span style="font-family: verdana,sans-serif;">ASSERT
INFO:</span><br style="font-family: verdana,sans-serif;">
<span style="font-family:
verdana,sans-serif;">../src/common/filename.cpp(476): assert
&quot;volDummy.empty() &amp;&amp; pathDummy.empty()&quot; failed in
Assign(): the file name shouldn&#39;t contain the path</span><br
style="font-family: verdana,sans-serif;">
<br style="font-family: verdana,sans-serif;"><span style="font-family:
verdana,sans-serif;">BACKTRACE:</span><br style="font-family:
verdana,sans-serif;"><span style="font-family: verdana,sans-serif;">[1]
wxFileDialog::wxFileDialog(wxWindow*, wxString const&amp;, wxString
const&amp;, wxString const&amp;, wxString const&amp;, long, wxPoint
const&amp;, wxSize const&amp;, wxString const&amp;)</span><br
style="font-family: verdana,sans-serif;">
<span style="font-family: verdana,sans-serif;">[2]
frmRestore::OnSelectFilename(wxCommandEvent&amp;)
/projects/pgadmin/40_line_numbers_in_sql_view/7/pgadmin/./frm/frmRestore.cpp:136</span><br
style="font-family: verdana,sans-serif;">
<span style="font-family: verdana,sans-serif;">[3]
wxEvtHandler::ProcessEventIfMatches(wxEventTableEntryBase const&amp;,
wxEvtHandler*, wxEvent&amp;)</span><br style="font-family:
verdana,sans-serif;"><span style="font-family: verdana,sans-serif;">[4]
wxEventHashTable::HandleEvent(wxEvent&amp;, wxEvtHandler*)</span><br
style="font-family: verdana,sans-serif;">
<span style="font-family: verdana,sans-serif;">[5]
wxEvtHandler::ProcessEvent(wxEvent&amp;)</span><br style="font-family:
verdana,sans-serif;"><span style="font-family: verdana,sans-serif;">[6]
wxWindowBase::TryParent(wxEvent&amp;)</span><br style="font-family:
verdana,sans-serif;">
<span style="font-family: verdana,sans-serif;">[7]
wxEvtHandler::ProcessEvent(wxEvent&amp;)</span><br style="font-family:
verdana,sans-serif;"><span style="font-family: verdana,sans-serif;">[8]
wxWindowBase::TryParent(wxEvent&amp;)</span><br style="font-family:
verdana,sans-serif;">
<span style="font-family: verdana,sans-serif;">[9]
wxEvtHandler::ProcessEvent(wxEvent&amp;)</span><br style="font-family:
verdana,sans-serif;"><span style="font-family: verdana,sans-serif;">[10]
wxWindowBase::TryParent(wxEvent&amp;)</span><br style="font-family:
verdana,sans-serif;">
<span style="font-family: verdana,sans-serif;">[11]
wxEvtHandler::ProcessEvent(wxEvent&amp;)</span><br style="font-family:
verdana,sans-serif;"><span style="font-family: verdana,sans-serif;">[12]
g_closure_invoke()</span><br style="font-family: verdana,sans-serif;">
<span style="font-family: verdana,sans-serif;">[13]
g_signal_emit_valist()</span><br style="font-family:
verdana,sans-serif;"><span style="font-family: verdana,sans-serif;">[14]
g_signal_emit()</span><br style="font-family: verdana,sans-serif;">
<span style="font-family: verdana,sans-serif;">[15]
g_closure_invoke()</span><br style="font-family:
verdana,sans-serif;"><span style="font-family: verdana,sans-serif;">[16]
g_signal_emit_valist()</span><br style="font-family: verdana,sans-serif;">
<span style="font-family: verdana,sans-serif;">[17]
g_signal_emit()</span><br style="font-family: verdana,sans-serif;"><span
style="font-family: verdana,sans-serif;">[18] g_closure_invoke()</span><br
style="font-family: verdana,sans-serif;">
<span style="font-family: verdana,sans-serif;">[19]
g_signal_emit_valist()</span><br style="font-family:
verdana,sans-serif;"><span style="font-family: verdana,sans-serif;">[20]
g_signal_emit()</span><br style="font-family: verdana,sans-serif;">
<span style="font-family: verdana,sans-serif;">[21]
gtk_propagate_event()</span><br style="font-family:
verdana,sans-serif;"><span style="font-family: verdana,sans-serif;">[22]
gtk_main_do_event()</span><br style="font-family: verdana,sans-serif;">
<span style="font-family: verdana,sans-serif;">[23]
g_main_context_dispatch()</span><br style="font-family:
verdana,sans-serif;"><span style="font-family: verdana,sans-serif;">[24]
g_main_loop_run()</span><br style="font-family: verdana,sans-serif;">
<span style="font-family: verdana,sans-serif;">[25] gtk_main()</span><br
style="font-family: verdana,sans-serif;">

------=_Part_5931_33119596.1209001191315--

------=_Part_5930_11150387.1209001191315
Content-Type: text/x-diff; name=BackupRestor.patch
Content-Transfer-Encoding: base64
X-Attachment-Id: f_ffeo16uz0
Content-Disposition: attachment; filename=BackupRestor.patch

SW5kZXg6IHBnYWRtaW4vZnJtL2ZybUJhY2t1cC5jcHAKPT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PQotLS0gcGdhZG1pbi9mcm0vZnJtQmFja3VwLmNwcAkocmV2
aXNpb24gNzIzNykKKysrIHBnYWRtaW4vZnJtL2ZybUJhY2t1cC5jcHAJKHdv
cmtpbmcgY29weSkKQEAgLTExMiw3ICsxMTIsNyBAQAogCiB2b2lkIGZybUJh
Y2t1cDo6T25TZWxlY3RGaWxlbmFtZSh3eENvbW1hbmRFdmVudCAmZXYpCiB7
Ci0gICAgd3hTdHJpbmcgdGl0bGUsIHByb21wdDsKKyAgICB3eFN0cmluZyB0
aXRsZSwgcHJvbXB0LCBGaWxlbmFtZU9ubHk7CiAKICAgICBpZiAocmJ4Rm9y
bWF0LT5HZXRTZWxlY3Rpb24oKSA9PSAyKSAvLyBwbGFpbgogICAgIHsKQEAg
LTEyNSw4ICsxMjUsOCBAQAogICAgICAgICBwcm9tcHQgPSBfKCJCYWNrdXAg
ZmlsZXMgKCouYmFja3VwKXwqLmJhY2t1cHxBbGwgZmlsZXMgKCouKil8Ki4q
Iik7CiAgICAgfQogCi0gICAgCi0gICAgd3hGaWxlRGlhbG9nIGZpbGUodGhp
cywgdGl0bGUsIDo6d3hQYXRoT25seSh0eHRGaWxlbmFtZS0+R2V0VmFsdWUo
KSksIHR4dEZpbGVuYW1lLT5HZXRWYWx1ZSgpLCBwcm9tcHQsIHd4RkRfU0FW
RSk7CisgICAgd3hGaWxlTmFtZTo6U3BsaXRQYXRoKHR4dEZpbGVuYW1lLT5H
ZXRWYWx1ZSgpLCBOVUxMLCBOVUxMLCAmRmlsZW5hbWVPbmx5LCBOVUxMKTsK
KyAgICB3eEZpbGVEaWFsb2cgZmlsZSh0aGlzLCB0aXRsZSwgOjp3eFBhdGhP
bmx5KHR4dEZpbGVuYW1lLT5HZXRWYWx1ZSgpKSwgRmlsZW5hbWVPbmx5LCBw
cm9tcHQsIHd4RkRfU0FWRSk7CiAKICAgICBpZiAoZmlsZS5TaG93TW9kYWwo
KSA9PSB3eElEX09LKQogICAgIHsKSW5kZXg6IHBnYWRtaW4vZnJtL2ZybVJl
c3RvcmUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHBnYWRtaW4v
ZnJtL2ZybVJlc3RvcmUuY3BwCShyZXZpc2lvbiA3MjM3KQorKysgcGdhZG1p
bi9mcm0vZnJtUmVzdG9yZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEzMiw3
ICsxMzIsMTEgQEAKIAogdm9pZCBmcm1SZXN0b3JlOjpPblNlbGVjdEZpbGVu
YW1lKHd4Q29tbWFuZEV2ZW50ICZldikKIHsKLSAgICB3eEZpbGVEaWFsb2cg
ZmlsZSh0aGlzLCBfKCJTZWxlY3QgYmFja3VwIGZpbGVuYW1lIiksIDo6d3hQ
YXRoT25seSh0eHRGaWxlbmFtZS0+R2V0VmFsdWUoKSksIHR4dEZpbGVuYW1l
LT5HZXRWYWx1ZSgpLCAKKyAgICAKKyAgICB3eFN0cmluZyBGaWxlbmFtZU9u
bHk7ICAgIAorICAgIHd4RmlsZU5hbWU6OlNwbGl0UGF0aCh0eHRGaWxlbmFt
ZS0+R2V0VmFsdWUoKSwgTlVMTCwgTlVMTCwgJkZpbGVuYW1lT25seSwgTlVM
TCk7CisgICAgCisgICAgd3hGaWxlRGlhbG9nIGZpbGUodGhpcywgXygiU2Vs
ZWN0IGJhY2t1cCBmaWxlbmFtZSIpLCA6Ond4UGF0aE9ubHkodHh0RmlsZW5h
bWUtPkdldFZhbHVlKCkpLCBGaWxlbmFtZU9ubHksIAogICAgICAgICBfKCJC
YWNrdXAgZmlsZXMgKCouYmFja3VwKXwqLmJhY2t1cHxBbGwgZmlsZXMgKCou
Kil8Ki4qIikpOwogCiAgICAgaWYgKGZpbGUuU2hvd01vZGFsKCkgPT0gd3hJ
RF9PSykK

------=_Part_5930_11150387.1209001191315
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@[EMAIL PROTECTED]
)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

------=_Part_5930_11150387.1209001191315--