Talk About Network

Google


Register and Login
Nick
Password
Register create new account Sign up is FREE and you can post replies, new topics, bookmark posts and more!
Recover lost password


Data Bases > Pgsql Patches > Re: float4/floa...
Latest [ Topics | Posts ] Archive Post A New Topic Post a Reply
<< Topic < Post Post 1 of 4 Topic 3615 of 3861
Post > Topic >>

Re: float4/float8/int64 passed by value with tsearchfixup

by stark@[EMAIL PROTECTED] (Gregory Stark) Apr 20, 2008 at 08:32 AM

"Tom Lane" <tgl@[EMAIL PROTECTED]
> writes:

> BTW, I trolled the contrib files for other v0 functions taking or
> returning float4 or float8.  I found seg_size (fixed it) and a whole
> bunch of functions in earthdistance.  Those use float8 not float4,
> so they are not broken by this patch, but that module will have to
> be v1-ified before we can consider applying the other part of the
> patch.

So are you killing V0 for non-integral types? Because if not we should
keep
some sacrificial module to the regression tests to use to test for this
problem.

I don't see any way not to kill v0 for non-integral types if we want to
make
float4 and float8 pass-by-value. We could leave those pass-by-reference
and
just make bigint pass-by-value.

-- 
  Gregory Stark
  EnterpriseDB          http://www.enterprisedb.com
  Ask me about EnterpriseDB's On-Demand Production Tuning

-- 
Sent via pgsql-patches mailing list (pgsql-patches@[EMAIL PROTECTED]
)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-patches




 4 Posts in Topic:
Re: float4/float8/int64 passed by value with tsearchfixup
stark@[EMAIL PROTECTED]   2008-04-20 08:32:59 
Re: float4/float8/int64 passed by value with tsearchfixup
zb@[EMAIL PROTECTED] (Zo  2008-04-20 16:54:28 
Re: float4/float8/int64 passed by value with tsearchfixup
tgl@[EMAIL PROTECTED] (T  2008-04-20 11:57:07 
Re: float4/float8/int64 passed by value with
bruce@[EMAIL PROTECTED]   2008-04-21 11:45:52 

Post A Reply:
  Go here to Signup

AddThis Feed Button


About - Advertising - Contact - Frequently Asked Questions - Privacy Policy - Terms of Use - Signup

Contact
tan13V112 Fri Jul 4 9:27:51 CDT 2008.