Talk About Network

Google


Register and Login
Nick
Password
Register create new account Sign up is FREE and you can post replies, new topics, bookmark posts and more!
Recover lost password


Data Bases > Pgsql Patches > Re: Improve shu...
Latest [ Topics | Posts ] Archive Post A New Topic Post a Reply
<< Topic < Post Post 1 of 1 Topic 3623 of 3966
Post > Topic >>

Re: Improve shutdown during online backup, take 4

by magnus@[EMAIL PROTECTED] (Magnus Hagander) Apr 23, 2008 at 10:43 AM

Albe Laurenz wrote:
> Magnus Hagander wrote:
> > This doesn't look like our normal coding standards, and should
> > probably be changed:
> > + 	if (0 != stat(BACKUP_LABEL_FILE, &stat_buf))
> > 
> > (there's a number of similar places)
> 
> I see. Lacking guidelines, I now copied how stat(2) is used in
> other parts of the code.

Really? I thought we didn't do that :), and I recall having my own
patches bounced for the same reason.

Just to be sure, we are talking about the
if (0 == foo)
vs
if (foo == 0)

thing, right? If not, then I wasn't clear enough in my note :-(

//Magnus

-- 
Sent via pgsql-patches mailing list (pgsql-patches@[EMAIL PROTECTED]
)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-patches
 




 1 Posts in Topic:
Re: Improve shutdown during online backup, take 4
magnus@[EMAIL PROTECTED]   2008-04-23 10:43:23 

Post A Reply:
  Go here to Signup

AddThis Feed Button


About - Advertising - Contact - Frequently Asked Questions - Privacy Policy - Terms of Use - Signup

Contact
tan12V112 Sat Sep 6 15:26:38 CDT 2008.