Talk About Network

Google


Register and Login
Nick
Password
Register create new account Sign up is FREE and you can post replies, new topics, bookmark posts and more!
Recover lost password


Data Bases > Pgsql Patches > Re: Improve shu...
Latest [ Topics | Posts ] Archive Post A New Topic Post a Reply
<< Topic < Post Post 1 of 3 Topic 3625 of 3916
Post > Topic >>

Re: Improve shutdown during online backup, take 4

by magnus@[EMAIL PROTECTED] (Magnus Hagander) Apr 23, 2008 at 03:45 PM

Albe Laurenz wrote:
> Magnus Hagander wrote:
> > This doesn't look like our normal coding standards, and should
> > probably be changed:
> > + 	if (0 != stat(BACKUP_LABEL_FILE, &stat_buf))
> > 
> > (there's a number of similar places)
> 
> I see. Lacking guidelines, I now copied how stat(2) is used in
> other parts of the code.

Applied with some minor changes to the error messages to make them
closer to our guidelines. (With my track record, it's not entirely
unlikely that someone will fix them further though :-P)

//Magnus

-- 
Sent via pgsql-patches mailing list (pgsql-patches@[EMAIL PROTECTED]
)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-patches
 




 3 Posts in Topic:
Re: Improve shutdown during online backup, take 4
magnus@[EMAIL PROTECTED]   2008-04-23 15:45:40 
Re: Improve shutdown during online backup, take 4
alvherre@[EMAIL PROTECTED  2008-04-23 10:02:54 
Re: Improve shutdown during online backup, take 4
laurenz.albe@[EMAIL PROTE  2008-04-23 16:12:45 

Post A Reply:
  Go here to Signup

AddThis Feed Button


About - Advertising - Contact - Frequently Asked Questions - Privacy Policy - Terms of Use - Signup

Contact
tan13V112 Thu Jul 24 5:09:09 CDT 2008.