Talk About Network

Google


Register and Login
Nick
Password
Register create new account Sign up is FREE and you can post replies, new topics, bookmark posts and more!
Recover lost password


Data Bases > Pgsql Patches > Re: Removing ty...
Latest [ Topics | Posts ] Archive Post A New Topic Post a Reply
<< Topic < Post Post 1 of 9 Topic 3636 of 3917
Post > Topic >>

Re: Removing typename from A_Const (was: Empty arrays

by alvherre@[EMAIL PROTECTED] (Alvaro Herrera) Apr 28, 2008 at 12:27 PM

Brendan Jurd escribió:

> Here's my attempt to remove the typename field from A_Const.  There
> were a few places (notably flatten_set_variable_args() in guc.c, and
> typenameTypeMod() in parse_type.c) where the code expected to see an
> A_Const with a typename, and I had to adjust for an A_Const within a
> TypeCast.  Nonetheless, there was an overall net reduction of 34 lines
> of code, so I think this was a win.

Do say ... why don't we do away with A_Const altogether and just replace
it with Value?  After this patch, I don't see what's the difference.

-- 
Alvaro Herrera                               
http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 sup****t

-- 
Sent via pgsql-patches mailing list (pgsql-patches@[EMAIL PROTECTED]
)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-patches
 




 9 Posts in Topic:
Re: Removing typename from A_Const (was: Empty arrays
alvherre@[EMAIL PROTECTED  2008-04-28 12:27:02 
Re: Removing typename from A_Const (was: Empty arrays with ARRAY
tgl@[EMAIL PROTECTED] (T  2008-04-28 12:50:18 
Re: [HACKERS] Removing typename from A_Const (was: Empty
alvherre@[EMAIL PROTECTED  2008-04-28 12:54:34 
Re: [HACKERS] Removing typename from A_Const (was: Empty arrays
tgl@[EMAIL PROTECTED] (T  2008-04-28 13:05:38 
Re: [HACKERS] Removing typename from A_Const (was: Empty
alvherre@[EMAIL PROTECTED  2008-04-28 16:25:03 
Re: [HACKERS] Removing typename from A_Const (was: Empty
alvherre@[EMAIL PROTECTED  2008-04-28 16:55:15 
Re: [HACKERS] Removing typename from A_Const (was: Empty arrays
tgl@[EMAIL PROTECTED] (T  2008-04-28 17:07:28 
Re: [HACKERS] Removing typename from A_Const (was: Empty arrays
tgl@[EMAIL PROTECTED] (T  2008-04-28 16:57:11 
Re: [HACKERS] Removing typename from A_Const (was: Empty
alvherre@[EMAIL PROTECTED  2008-04-28 17:01:25 

Post A Reply:
  Go here to Signup

AddThis Feed Button


About - Advertising - Contact - Frequently Asked Questions - Privacy Policy - Terms of Use - Signup

Contact
tan13V112 Thu Jul 24 12:39:08 CDT 2008.