Talk About Network

Google


Register and Login
Nick
Password
Register create new account Sign up is FREE and you can post replies, new topics, bookmark posts and more!
Recover lost password


Data Bases > Pgsql Patches > Re: [COMMITTERS...
Latest [ Topics | Posts ] Archive Post A New Topic Post a Reply
<< Topic < Post Post 5 of 9 Topic 3673 of 3966
Post > Topic >>

Re: [COMMITTERS] pgsql: Sigh ...

by andrew@[EMAIL PROTECTED] (Andrew Dunstan) May 2, 2008 at 07:05 PM

Tom Lane wrote:
> Andrew Dunstan <andrew@[EMAIL PROTECTED]
> writes:
>   
>> ! 		print O "#define RELSEG_SIZE ",
>> ! 			(1024 / $self->{options}->{blocksize}) * 
>> ! 				$self->{options}->{segsize} * 1024, "\n";
>>     
>
> This doesn't look quite right; unless the arithmetic is being done in
> floating point?  I had it like this in configure.in:
>
> RELSEG_SIZE=`expr '(' 1024 '*' ${segsize} / ${blocksize} ')' '*' 1024`
>   

blocksize is one of (1,2,4,8,16,32)  so it should always be a factor of 
1024 unless my arithmetic is awry. I did it that way because I dislike 
expressions with  unbracketed mixed operations - they make me think too 
much.

> Also it looks like you missed adding segsize to the config.pl comments.
>
> 			
>   

That's deliberate - we are currently only allowing a value of 1 here, so 
I don't see any point in putting it in the sample config file, even as a 
comment. When we enable other seg sizes we can add it to the sample file.

cheers

andrew



-- 
Sent via pgsql-patches mailing list (pgsql-patches@[EMAIL PROTECTED]
)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-patches
 




 9 Posts in Topic:
Re: [COMMITTERS] pgsql: Sigh ...
andrew@[EMAIL PROTECTED]   2008-05-02 18:18:29 
Re: [COMMITTERS] pgsql: Sigh ...
tgl@[EMAIL PROTECTED] (T  2008-05-02 18:28:41 
Re: [COMMITTERS] pgsql: Sigh ...
tgl@[EMAIL PROTECTED] (T  2008-05-02 19:23:34 
Re: [COMMITTERS] pgsql: Sigh ...
andrew@[EMAIL PROTECTED]   2008-05-02 20:26:29 
Re: [COMMITTERS] pgsql: Sigh ...
andrew@[EMAIL PROTECTED]   2008-05-02 19:05:05 
Re: [COMMITTERS] pgsql: Sigh ...
peter_e@[EMAIL PROTECTED]  2008-05-03 11:15:01 
Re: [COMMITTERS] pgsql: Sigh ...
andrew@[EMAIL PROTECTED]   2008-05-03 09:11:26 
Re: [COMMITTERS] pgsql: Sigh ...
tgl@[EMAIL PROTECTED] (T  2008-05-03 13:17:34 
Re: [COMMITTERS] pgsql: Sigh ...
magnus@[EMAIL PROTECTED]   2008-05-03 21:20:30 

Post A Reply:
  Go here to Signup

AddThis Feed Button


About - Advertising - Contact - Frequently Asked Questions - Privacy Policy - Terms of Use - Signup

Contact
tan12V112 Sat Sep 6 15:25:15 CDT 2008.