Re: [COMMITTERS] pgsql: Sigh ...

Tom Lane wrote:
> Andrew Dunstan <andrew@[EMAIL PROTECTED]
> writes:
>   
>> ! 		print O "#define RELSEG_SIZE ",
>> ! 			(1024 / $self->{options}->{blocksize}) * 
>> ! 				$self->{options}->{segsize} * 1024, "\n";
>>     
>
> This doesn't look quite right; unless the arithmetic is being done in
> floating point?  I had it like this in configure.in:
>
> RELSEG_SIZE=`expr '(' 1024 '*' ${segsize} / ${blocksize} ')' '*' 1024`
>   

blocksize is one of (1,2,4,8,16,32)  so it should always be a factor of 
1024 unless my arithmetic is awry. I did it that way because I dislike 
expressions with  unbracketed mixed operations - they make me think too 
much.

> Also it looks like you missed adding segsize to the config.pl comments.
>
> 			
>   

That's deliberate - we are currently only allowing a value of 1 here, so 
I don't see any point in putting it in the sample config file, even as a 
comment. When we enable other seg sizes we can add it to the sample file.

cheers

andrew



-- 
Sent via pgsql-patches mailing list (pgsql-patches@[EMAIL PROTECTED]
)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-patches