Talk About Network

Google


Register and Login
Nick
Password
Register create new account Sign up is FREE and you can post replies, new topics, bookmark posts and more!
Recover lost password


Data Bases > Pgsql Patches > Re: Exposing ke...
Latest [ Topics | Posts ] Archive Post A New Topic Post a Reply
<< Topic < Post Post 5 of 5 Topic 3676 of 4088
Post > Topic >>

Re: Exposing keywords to clients

by tgl@[EMAIL PROTECTED] (Tom Lane) May 3, 2008 at 04:06 PM

"Dave Page" <dpage@[EMAIL PROTECTED]
> writes:
> Attached is an updated patch, giving the following output.

Oh, one other thing: dropping externs into random modules unrelated to
their source module is completely awful programming style, because there
is nothing preventing incompatible declarations.  Put those externs in
keywords.h instead.  I suspect you have ignored a compiler warning
about not declaring pg_get_keywords itself, too --- it should be
extern'd in builtins.h.

			regards, tom lane

-- 
Sent via pgsql-patches mailing list (pgsql-patches@[EMAIL PROTECTED]
)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-patches
 




 5 Posts in Topic:
Re: Exposing keywords to clients
dpage@[EMAIL PROTECTED]   2008-05-03 08:15:14 
Re: Exposing keywords to clients
peter_e@[EMAIL PROTECTED]  2008-05-03 11:17:38 
Re: Exposing keywords to clients
tgl@[EMAIL PROTECTED] (T  2008-05-03 13:12:41 
Re: Exposing keywords to clients
tgl@[EMAIL PROTECTED] (T  2008-05-03 16:00:51 
Re: Exposing keywords to clients
tgl@[EMAIL PROTECTED] (T  2008-05-03 16:06:54 

Post A Reply:
  Go here to Signup

AddThis Feed Button


About - Advertising - Contact - Frequently Asked Questions - Privacy Policy - Terms of Use - Signup

Contact
tan12V112 Sun Oct 12 14:21:06 CDT 2008.