Talk About Network

Google


Register and Login
Nick
Password
Register create new account Sign up is FREE and you can post replies, new topics, bookmark posts and more!
Recover lost password


Data Bases > Pgsql Patches > Re: Verified fi...
Latest [ Topics | Posts ] Archive Post A New Topic Post a Reply
<< Topic < Post Post 14 of 15 Topic 3690 of 4084
Post > Topic >>

Re: Verified fix for Bug 4137

by heikki@[EMAIL PROTECTED] ("Heikki Linnakangas") May 9, 2008 at 03:37 PM

Simon Riggs wrote:
>   	if (restartWALFileName)
>   	{
> + 		/*
> + 		 * Don't do cleanup if the restartWALFileName provided
> + 		 * is later than the xlog file requested. This is an error
> + 		 * and we must not remove these files from archive.
> + 		 * This shouldn't happen, but better safe than sorry.
> + 		 */
> + 		if (strcmp(restartWALFileName, nextWALFileName) > 0)
> + 			return false;
> + 
>   		strcpy(exclusiveCleanupFileName, restartWALFileName);
>   		return true;
>   	}

I committed this sanity check into pg_standy, though it really shouldn't 
happen, but it just occurred to me that the most likely reason for that 
to happen is probably that the user has screwed up his restore_command 
line, mixing up the  %p and %r arguments. Should we make that an error 
instead of just not doing the cleanup?

-- 
   Heikki Lin****angas
   EnterpriseDB   http://www.enterprisedb.com

-- 
Sent via pgsql-patches mailing list (pgsql-patches@[EMAIL PROTECTED]
)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-patches
 




 15 Posts in Topic:
Verified fix for Bug 4137
simon@[EMAIL PROTECTED]   2008-05-06 09:30:49 
Re: Verified fix for Bug 4137
heikki@[EMAIL PROTECTED]   2008-05-06 12:02:56 
Re: Verified fix for Bug 4137
simon@[EMAIL PROTECTED]   2008-05-06 12:23:03 
Re: Verified fix for Bug 4137
simon@[EMAIL PROTECTED]   2008-05-06 14:44:04 
Re: Verified fix for Bug 4137
heikki@[EMAIL PROTECTED]   2008-05-06 15:00:17 
Re: Verified fix for Bug 4137
simon@[EMAIL PROTECTED]   2008-05-06 16:03:54 
Re: Verified fix for Bug 4137
heikki@[EMAIL PROTECTED]   2008-05-06 17:52:11 
Re: Verified fix for Bug 4137
simon@[EMAIL PROTECTED]   2008-05-06 20:41:01 
Re: Verified fix for Bug 4137
heikki@[EMAIL PROTECTED]   2008-05-06 21:51:19 
Re: Verified fix for Bug 4137
simon@[EMAIL PROTECTED]   2008-05-07 00:29:17 
Re: Verified fix for Bug 4137
heikki@[EMAIL PROTECTED]   2008-05-09 15:31:43 
Re: Verified fix for Bug 4137
tgl@[EMAIL PROTECTED] (T  2008-05-09 11:18:44 
Re: Verified fix for Bug 4137
heikki@[EMAIL PROTECTED]   2008-05-09 16:33:09 
Re: Verified fix for Bug 4137
heikki@[EMAIL PROTECTED]   2008-05-09 15:37:12 
Re: Verified fix for Bug 4137
simon@[EMAIL PROTECTED]   2008-05-09 15:52:16 

Post A Reply:
  Go here to Signup

AddThis Feed Button


About - Advertising - Contact - Frequently Asked Questions - Privacy Policy - Terms of Use - Signup

Contact
tan12V112 Sat Oct 11 20:24:02 CDT 2008.