Re: pg_dump lock timeout

On 5/11/08, daveg <daveg@[EMAIL PROTECTED]
> wrote:
>  Attached is a patch to add a commandline option to pg_dump to limit how
long
>  pg_dump will wait for locks during startup.

My quick review:

- It does not seem im****tant enough to waste a short option on.
  Having only long option should be enough.

- It would be more polite to do SET LOCAL instead SET.
  (Eg. it makes safer to use pg_dump through pooler.)

- The statement_timeout is set back with "statement_timeout = default"
  Maybe it would be better to do "= 0" here?  Although such decision
  would go outside the scope of the patch, I see no sense having
  any other statement_timeout for actual dumping.

-- 
marko

-- 
Sent via pgsql-patches mailing list (pgsql-patches@[EMAIL PROTECTED]
)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-patches